chore: TODOs for reviews #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 11.69% 11.64% -0.05%
==========================================
Files 83 83
Lines 19338 19520 +182
==========================================
+ Hits 2262 2274 +12
- Misses 16839 17004 +165
- Partials 237 242 +5
|
…relay into review/chain-providers
viveksharmapoudel
previously approved these changes
Jul 25, 2023
viveksharmapoudel
previously approved these changes
Jul 25, 2023
viveksharmapoudel
approved these changes
Jul 25, 2023
izyak
added a commit
to izyak/ibc-relay-test
that referenced
this pull request
Sep 7, 2023
* chore: TODOs for reviews * chore: remove move method from interface * chore: panic unimplemented methods * feat: Validate archway and icon addresses * chore: comments * chore: use enums to compare * feat: contract address validation * chore: rename method for contract address * fix: remove some comments * chore: save contract addrss size to const * chore: use actual address to fix tests --------- Co-authored-by: izyak <[email protected]> Co-authored-by: viveksharmapoudel <[email protected]>
izyak
added a commit
that referenced
this pull request
Sep 8, 2023
* chore: TODOs for reviews * chore: remove move method from interface * chore: panic unimplemented methods * feat: Validate archway and icon addresses * chore: comments * chore: use enums to compare * feat: contract address validation * chore: rename method for contract address * fix: remove some comments * chore: save contract addrss size to const * chore: use actual address to fix tests --------- Co-authored-by: izyak <[email protected]> Co-authored-by: viveksharmapoudel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.